New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ActionButton.js): improving filter to catch childrens of ActionButton #1

Merged

shobhitsinghal624 merged 1 commit into chakrahq:master from RobertDS07:fix/improving-_renderActions

Sep 21, 2022

Member

shobhitsinghal624 commented Sep 21, 2022

Original source: mastermoo#373

Improving filter because if children is rendering with a condition ex.:

{callcenter_phone ? (
        <ActionButton.Item
          onPress={handleOpenCall}
          buttonColor={childrenColor || theme.colors.primary}
        >
          <Icon name="phone" type="FontAwesome" />
        </ActionButton.Item>
) : null}

It pass in filter because typeof null is 'object'

This PR closes mastermoo#366


          fix(ActionButton.js): improving actionButtons.filter of _renderAction…

fa1bce4

…s to not catch childrens that be 'null'

shobhitsinghal624 merged commit fbc684b into chakrahq:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet