Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to browser.js #122

Closed
wants to merge 1 commit into from
Closed

Update to browser.js #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-env browser */

const isBlinkBasedBrowser = /\b(Chrome|Chromium)\//.test(navigator.userAgent);
const isBlinkBasedBrowser = typeof navigator !== 'undefined' ? /\b(Chrome|Chromium)\//.test(navigator.userAgent): false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isBlinkBasedBrowser = typeof navigator !== 'undefined' ? /\b(Chrome|Chromium)\//.test(navigator.userAgent): false;
const isBlinkBasedBrowser = typeof navigator !== 'undefined' && /\b(Chrome|Chromium)\//.test(navigator.userAgent);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RHS of the : in a ternary is implicitly the false case, so this can be simplified as such - namely that the short-circuit will result in a false and RegExp.prototype.text() returns a boolean.


const colorSupport = isBlinkBasedBrowser ? {
level: 1,
Expand Down