Merge pull request #5656 from christianbeeznest/ofaj-21855

Internal: Fix DQL query in exerciseResultsInRanking function - refs BT#21855
chamilo · Jul 11, 2024 · 1ee4da7 · 1ee4da7
2 parents 2395d82 + 6d4d34b
commit 1ee4da7
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/public/main/inc/lib/exercise.lib.php b/public/main/inc/lib/exercise.lib.php
@@ -4842,8 +4842,8 @@ public static function exerciseResultsInRanking($exerciseId, $courseId, $session
     {
         $em = Database::getManager();
 
-        $dql = 'SELECT DISTINCT te.exeUserId FROM ChamiloCoreBundle:TrackEExercise te WHERE te.exeExoId = :id AND te.course = :cId';
-        $dql .= api_get_session_condition($sessionId, true, false, 'te.sessionId');
+        $dql = 'SELECT DISTINCT u.id FROM ChamiloCoreBundle:TrackEExercise te JOIN te.user u WHERE te.quiz = :id AND te.course = :cId';
+        $dql .= api_get_session_condition($sessionId, true, false, 'te.session');
 
         $result = $em
             ->createQuery($dql)
@@ -4853,7 +4853,14 @@ public static function exerciseResultsInRanking($exerciseId, $courseId, $session
         $data = [];
 
         foreach ($result as $item) {
-            $data[] = self::get_best_attempt_by_user($item['exeUserId'], $exerciseId, $courseId, $sessionId);
+            $attempt = self::get_best_attempt_by_user($item['id'], $exerciseId, $courseId, $sessionId);
+            if (!empty($attempt) && isset($attempt['score']) && isset($attempt['exe_date'])) {
+                $data[] = $attempt;
+            }
+        }
+
+        if (empty($data)) {
+            return [];
         }
 
         usort(