Skip to content

Commit

Permalink
Internal: Fix to get course setting value to get visual theme - refs …
Browse files Browse the repository at this point in the history
…BT#21621
  • Loading branch information
AngelFQC committed Jul 1, 2024
1 parent 25c2963 commit 4119d5d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/CoreBundle/ServiceHelper/ThemeHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ public function getVisualTheme(): string
if ($course) {
$this->settingsCourseManager->setCourse($course);

$visualTheme = $this->settingsCourseManager->getSetting('course_theme');
$visualTheme = $this->settingsCourseManager->getCourseSettingValue('course_theme');

if (1 === (int) $this->settingsCourseManager->getSetting('allow_learning_path_theme')) {
if (1 === (int) $this->settingsCourseManager->getCourseSettingValue('allow_learning_path_theme')) {
global $lp_theme_css;

Check failure on line 56 in src/CoreBundle/ServiceHelper/ThemeHelper.php

View workflow job for this annotation

GitHub Actions / PHP 8.1 Test on ubuntu-latest

InvalidGlobal

src/CoreBundle/ServiceHelper/ThemeHelper.php:56:21: InvalidGlobal: Cannot use global scope here (unless this file is included from a non-global scope) (see https://psalm.dev/046)

$visualTheme = $lp_theme_css;

Check warning on line 58 in src/CoreBundle/ServiceHelper/ThemeHelper.php

View check run for this annotation

Codecov / codecov/patch

src/CoreBundle/ServiceHelper/ThemeHelper.php#L58

Added line #L58 was not covered by tests
Expand Down

0 comments on commit 4119d5d

Please sign in to comment.