Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System: Fix Behat scenario 'Enter to public password-protected course' - refs GH#1678 #4497

Open
wants to merge 14 commits into
base: 1.11.x
Choose a base branch
from

Conversation

BorjaSanchezBeezNest
Copy link
Contributor

No description provided.

@ywarnier
Copy link
Member

ywarnier commented Dec 22, 2022

The behat run by Github still returns an error on that precise test: https://github.com/chamilo/chamilo-lms/actions/runs/3697991616/jobs/6382177704

  Scenario: Enter to public password-protected course                                                # features/course.feature:161
    Given I have a public password-protected course named "PASSWORDPROTECTED" with password "123456" # FeatureContext::iHaveAPublicPasswordProtectedCourse()
      Form field with id|name|label|value|placeholder "course_registration_password" not found.

@ywarnier
Copy link
Member

Maybe a click must be sent to #collapse-course-access-settings to make sure the setting appears ?
Maybe behat has to be updated in composer.json to find a hidden form element ?
Not sure...

@BorjaSanchezBeezNest
Copy link
Contributor Author

After several tests, it has been fixed in local, but it continues to fail in GitHub tests
The error:
Form field with id|name|label|value|placeholder "course_registration_password" not found.

The following has been tried:

  • Upgrade Chrome driver version from '88.0.4324.96' to '108.0.5359.71'
  • Upgrade Selenium driver to '4.7.2', but any test work with this version
  • Change the test screen resolution from 1280x1024 to 1920x1080
  • Put ID in the link that is not recognized, with the same result

@ywarnier
Copy link
Member

ywarnier commented May 30, 2023

This PR is intentionally left "on hold" as it doesn't solve the issue in all contexts, but provides hints at a future solution.

@ywarnier ywarnier added this to the 1.11.28 milestone Jan 14, 2024
@ywarnier ywarnier removed this from the 1.11.28 milestone Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants