Internal: Add session replication, reinscription logic, and child session hierarchy for course expiration - refs BT#22057 #5831
Conversation
…sion hierarchy for course expiration - refs BT#22057
…ctionality - refs BT#22057
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,185 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
Add a single space around assignment operators
| use Symfony\Component\Console\Output\OutputInterface; | ||
| use Symfony\Component\Console\Input\InputOption; | ||
|
|
||
| class ReinscriptionCheckCommand extends Command |
| private SessionRepository $sessionRepository; | ||
| private EntityManagerInterface $entityManager; | ||
|
|
||
| public function __construct( |
| @@ -0,0 +1,205 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
Add a single space around assignment operators
| use Symfony\Component\Mime\Email; | ||
| use Symfony\Contracts\Translation\TranslatorInterface; | ||
|
|
||
| class SessionRepetitionCommand extends Command |
| @@ -654,6 +641,11 @@ public static function getSessionsForAdmin( | |||
| ) | |||
| )"; | |||
| break; | |||
| case 'replication': | |||
There was a problem hiding this comment.
CASE statements must be defined using a colon
| { | ||
| $sessions = []; | ||
| $tbl_session = Database::get_main_table(TABLE_MAIN_SESSION); | ||
| $sql = "SELECT id, title FROM $tbl_session WHERE parent_id IS NULL ORDER BY title"; |
There was a problem hiding this comment.
Variable "tbl_session" is not in valid camel caps format
| private MailerInterface $mailer; | ||
| private TranslatorInterface $translator; | ||
|
|
||
| public function __construct( |
| $newEndDate = (clone $newStartDate)->add($duration); | ||
|
|
||
| if ($debug) { | ||
| $output->writeln(sprintf('Duplicating session %d. New start date: %s, New end date: %s', |
There was a problem hiding this comment.
Opening parenthesis of a multi-line function call must be the last content on the line
| @@ -380,6 +380,18 @@ class Session implements ResourceWithAccessUrlInterface, Stringable | |||
| #[Groups(['user_subscriptions:sessions', 'session:read', 'session:item:read'])] | |||
| private int $accessVisibility = 0; | |||
|
|
|||
| #[ORM\Column(name: 'parent_id', type: 'integer', nullable: true)] | |||
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| @@ -380,6 +380,18 @@ class Session implements ResourceWithAccessUrlInterface, Stringable | |||
| #[Groups(['user_subscriptions:sessions', 'session:read', 'session:item:read'])] | |||
| private int $accessVisibility = 0; | |||
|
|
|||
| #[ORM\Column(name: 'parent_id', type: 'integer', nullable: true)] | |||
| protected ?int $parentId = null; | |||
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| #[ORM\Column(name: 'parent_id', type: 'integer', nullable: true)] | ||
| protected ?int $parentId = null; | ||
|
|
||
| #[ORM\Column(name: 'days_to_reinscription', type: 'integer', nullable: true)] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| protected ?int $parentId = null; | ||
|
|
||
| #[ORM\Column(name: 'days_to_reinscription', type: 'integer', nullable: true)] | ||
| protected ?int $daysToReinscription = null; |
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| #[ORM\Column(name: 'days_to_reinscription', type: 'integer', nullable: true)] | ||
| protected ?int $daysToReinscription = null; | ||
|
|
||
| #[ORM\Column(name: 'last_repetition', type: 'boolean', nullable: false, options: ['default' => false])] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| protected ?int $daysToReinscription = null; | ||
|
|
||
| #[ORM\Column(name: 'last_repetition', type: 'boolean', nullable: false, options: ['default' => false])] | ||
| protected bool $lastRepetition = false; |
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| #[ORM\Column(name: 'last_repetition', type: 'boolean', nullable: false, options: ['default' => false])] | ||
| protected bool $lastRepetition = false; | ||
|
|
||
| #[ORM\Column(name: 'days_to_new_repetition', type: 'integer', nullable: true)] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| protected bool $lastRepetition = false; | ||
|
|
||
| #[ORM\Column(name: 'days_to_new_repetition', type: 'integer', nullable: true)] | ||
| protected ?int $daysToNewRepetition = null; |
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| @@ -446,7 +458,7 @@ | |||
|
|
|||
| public function getShowDescription(): bool | |||
| { | |||
| return $this->showDescription; | |||
| return $this->showDescription ?? false; | |||
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
| @@ -1474,6 +1486,54 @@ | |||
| )); | |||
| } | |||
|
|
|||
| public function getParentId(): ?int | |||
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| @@ -1474,6 +1486,54 @@ | |||
| )); | |||
| } | |||
|
|
|||
| public function getParentId(): ?int | |||
…lidation - refs BT#22057
| return null; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
The closing brace for the class must go on the next line after the body
| @@ -1474,6 +1486,54 @@ public function getClosedOrHiddenCourses(): Collection | |||
| )); | |||
| } | |||
|
|
|||
| public function getParentId(): ?int | |||
| { | |||
| return $this->parentId; | |||
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
| return $this->parentId; | ||
| } | ||
|
|
||
| public function setParentId(?int $parentId): self |
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| return $this->parentId; | ||
| } | ||
|
|
||
| public function setParentId(?int $parentId): self |
|
|
||
| public function setParentId(?int $parentId): self | ||
| { | ||
| $this->parentId = $parentId; |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
| @@ -0,0 +1 @@ | |||
| <?php phpinfo(); ?> | |||
There was a problem hiding this comment.
A closing tag is not permitted at the end of a PHP file
| @@ -0,0 +1 @@ | |||
| <?php phpinfo(); ?> | |||
There was a problem hiding this comment.
A closing tag is not permitted at the end of a PHP file
| return $this; | ||
| } | ||
|
|
||
| public function getDaysToReinscription(): ?int |
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 4
| return $this; | ||
| } | ||
|
|
||
| public function getDaysToReinscription(): ?int |
|
|
||
| public function getDaysToReinscription(): ?int | ||
| { | ||
| return $this->daysToReinscription; |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
|
Code Climate has analyzed commit 7b66599 and detected 83 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.