close #2045 improve adding venue to product admin #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nangdypanhar
force-pushed
the
2045-add-nearby-places-suggestion
branch
2 times, most recently
from
5f9dc0f to
cfbf574
Compare
nangdypanhar
force-pushed
the
2045-add-nearby-places-suggestion
branch
2 times, most recently
from
62a6087 to
8407aac
Compare
nangdypanhar
changed the title
nangdypanhar
force-pushed
the
2045-add-nearby-places-suggestion
branch
2 times, most recently
from
8213496 to
03c4358
Compare
nangdypanhar
added
enhancement
nangdypanhar
force-pushed
the
2045-add-nearby-places-suggestion
branch
4 times, most recently
from
ba02ac8 to
78332af
Compare
nangdypanhar
changed the title
nangdypanhar
changed the title
nangdypanhar
force-pushed
the
2045-add-nearby-places-suggestion
branch
from
78332af to
a5c3476
Compare
theachoem
approved these changes
Nov 28, 2024
channainfo
requested changes
Nov 28, 2024
| end | ||
|
|
||
| def collection | ||
| @collection ||= begin |
There was a problem hiding this comment.
remove the begin statement here cause nested code. let's remove it.
|
|
||
| private | ||
|
|
||
| Place = Struct.new(:id, :name, :base_64_content) |
There was a problem hiding this comment.
Remove this Struct from global declaration in the controller, it might cause a conflict of type in the future.
| context.google_places = [] | ||
| json_response = fetch_google_place_by_name | ||
|
|
||
| json_response['results'].each_with_index do |json, _| |
| end | ||
|
|
||
| def fetch_google_place_by_name | ||
| url = URI("#{GOOGLE_MAP_API_URL}/place/textsearch/json?query=#{name}&key=#{google_map_key}") |
There was a problem hiding this comment.
Don't construct the query manually, it is not safe.
queries = {
query: name,
key: google_map_key
}.to_param
google_uri = URI("#{GOOGLE_MAP_API_URL}/place/textsearch/json?#{queries}")
|
|
||
| def fetch_google_place_by_name | ||
| url = URI("#{GOOGLE_MAP_API_URL}/place/textsearch/json?query=#{name}&key=#{google_map_key}") | ||
| https = Net::HTTP.new(url.host, url.port) |
There was a problem hiding this comment.
Use the Faraday instead of the Net. Make sure to keep the Http outbound request consitent by not employing other libs/classes
| Place.new( | ||
| id: place.reference, | ||
| name: place.name, | ||
| base_64_content: Base64.strict_encode64(place.to_json) |
There was a problem hiding this comment.
I forget. why do we need the base_64_content for?
There was a problem hiding this comment.
In form, we can only pass key & value bong. Because we want to pass all google place data, we need to encode it.
In controller, we can decode it back, and create place in database if not yet exist.
nangdypanhar
force-pushed
the
2045-add-nearby-places-suggestion
branch
2 times, most recently
from
7c74577 to
972724c
Compare
nangdypanhar
force-pushed
the
2045-add-nearby-places-suggestion
branch
from
972724c to
e31a208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo :
Screencast.from.2024-11-28.10-10-05.webm
Description :