close #2058 invalidate cache for frequently use API #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theachoem
force-pushed
the
2058-invalidate-cache-for-frequently-use-api
branch
from
1862001 to
92c2dad
Compare
theachoem
force-pushed
the
2058-invalidate-cache-for-frequently-use-api
branch
5 times, most recently
from
12ffaf0 to
121421e
Compare
channainfo
requested changes
Nov 19, 2024
| return unless request.get? || request.head? | ||
| return unless request.base_url == ENV['CONTENT_HOST_URL'] | ||
|
|
||
| response.set_header('Cache-Control', 'public, max-age=7200') |
There was a problem hiding this comment.
Let's make the 7200 in a ENV['CACHE_MAX_AGE']. and default it to 7200 if it does not exist.
theachoem
force-pushed
the
2058-invalidate-cache-for-frequently-use-api
branch
from
121421e to
0e39a3a
Compare
theachoem
force-pushed
the
2058-invalidate-cache-for-frequently-use-api
branch
from
0e39a3a to
dbc9981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Invalidate cache
Set cache to header for GET or HEAD. eg.
content.bookme.plusSince we use MiniProfilerRails, we can't set cache control at all. It will override.
Related PR: