Close #2180: enqueue generate BIB when order completed #2183
+111
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengsokly
force-pushed
the
2180-enqueue-generate-bib
branch
from
a196532 to
b512746
Compare
hengsokly
force-pushed
the
2180-enqueue-generate-bib
branch
from
b512746 to
ba598e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When payment is
completed, the order will update the state tocompleteand trigger guest togenerate_bib!(SpreeCmCommissioner::OrderBibNumberConcern)The bib_index is validated as unique
Users may make payments simultaneously that make the guest_bib_index duplicate and raise errors.
So applying to enqueue, but it may cause a delay and need to update the UI to handle the delay.
So need to verify with the cm-market-app to see how it affects the UI