Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #2196 prevent assigning random address to user #2197

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

theachoem
Copy link
Collaborator

@theachoem theachoem commented Dec 26, 2024

Issue

It only happens for guest orders (no user). This 1-minute video describes the issue:

Screen.Recording.2024-12-26.at.12.01.23.in.the.afternoon.mp4

Fixed & tested on staging

It no longer set random address.

image

@theachoem theachoem added the bug Something isn't working label Dec 26, 2024
@theachoem theachoem self-assigned this Dec 26, 2024
@theachoem theachoem requested a review from channainfo December 26, 2024 05:17
@theachoem theachoem force-pushed the 2196-prevent-assigning-random-address-to-user branch from 9704fbb to 58e578c Compare December 26, 2024 05:32
@channainfo channainfo merged commit 1bae128 into develop Dec 26, 2024
2 checks passed
@theachoem theachoem deleted the 2196-prevent-assigning-random-address-to-user branch December 26, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Prevent assigning existing bill / ship address when no basic info included
2 participants