Close #2249 Add section tab in taxon edit screen #2250
+81
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mengthong-ly
commented
Jan 10, 2025
•
mengthong-ly
commented
mengthong-ly
force-pushed
the
2249-add-section-tab-in-taxon-edit-screen
branch
from
73c01dc to
c1a0dd8
Compare
mengthong-ly
force-pushed
the
2249-add-section-tab-in-taxon-edit-screen
branch
from
c1a0dd8 to
33d4a19
Compare
channainfo
requested changes
Jan 11, 2025
| module Spree | ||
| module Admin | ||
| class ViewEventsController < Spree::Admin::ResourceController | ||
| before_action :load_taxonomy_taxon |
There was a problem hiding this comment.
explicitly add which action to apply:
before_action :load_taxonomy_taxon, only: [:index]
|
|
||
| def index | ||
| # Fetch the specific taxon associated with the taxonomy | ||
| @taxon = @taxonomy.taxons.find(params[:taxon_id]) |
There was a problem hiding this comment.
you don't need this because the load_taxonomy_taxon already does just this.
| @@ -0,0 +1,4 @@ | |||
| module SpreeCmCommissioner | |||
| class ViewEvent < ApplicationRecord | |||
There was a problem hiding this comment.
remove this, the model is linked to a table in the DB.
| @@ -0,0 +1,23 @@ | |||
| module Spree | |||
| module Admin | |||
| class ViewEventsController < Spree::Admin::ResourceController | |||
There was a problem hiding this comment.
Why not decorating the existing TaxonController? Naming a new controller can be challenging, and if the new controller is minimal, the additional effort might not be justified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.