Close #2247: stop retry fcm queue when missing notification record #2255
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengsokly
force-pushed
the
2247-stop-retry-when-notification-not-found
branch
from
1c199be to
a6040fc
Compare
hengsokly
force-pushed
the
2247-stop-retry-when-notification-not-found
branch
2 times, most recently
from
b75b2e9 to
43d8aa7
Compare
channainfo
requested changes
Jan 17, 2025
|
@hengsokly it looks great, just a tiny comment to checkout a file that has nothing to do with the issue. |
hengsokly
force-pushed
the
2247-stop-retry-when-notification-not-found
branch
2 times, most recently
from
e442dc4 to
286df12
Compare
hengsokly
force-pushed
the
2247-stop-retry-when-notification-not-found
branch
from
286df12 to
977db86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeliveryMethods::FcmDecoratorto enhance the functionality of FCM delivery.