Close #769 discount maximum cap

[kimsrung]

Form

Order detail

[theachoem]

It is great for whole order adjustment, but It will not work with item adjustment Or date-specific item adjustment.

Another approach we can do is putting CAP inside calculable of Spree::Calculator instead.

calculator is belongs_to :calculable. Caculatable here can be CreateAdjustment, CreateItemAdjustments, or CreateDateSpecificItemAdjustments.

Then, we can override compute method or override it logic based on a specific calculator:

def compute
   return super unless calculable.defined?(:cap)

   [super, calculable.cap].min
end

This will be a lot of change but please take it into consideration.

[kimsrung]

It is great for whole order adjustment, but It will not work with item adjustment Or date-specific item adjustment.

Another approach we can do is putting CAP inside calculable of Spree::Calculator instead.

calculator is belongs_to :calculable. Caculatable here can be CreateAdjustment, CreateItemAdjustments, or CreateDateSpecificItemAdjustments.

Then, we can override compute method or override it logic based on a specific calculator:

def compute
   return super unless calculable.defined?(:cap)

   [super, calculable.cap].min
end

This will be a lot of change but please take it into consideration.

From what I know, we apply cap to whole order only. We would get final price and calculate. And this cap would be on promotion only. In case you apply the promotion without cap, everything is still the same. We can write spec to verify this.

[kimsrung]

bong @channainfo , after refactoring code I think we are no longer need cap on promotion. As of now, I still keep my old code but I would like to remove that after discussion.

Also these classes:

• Promotion::Actions::CreateItemAdjustments
• Promotion::Actions::CreateDateSpecificItemAdjustments
  are using the same calculator Spree::Calculator::PercentOnLineItem, so override compute function here would affect all.

as of ItemTotal adjustment, we shall modify in this Spree::Calculator::FlatPercentItemTotal

@theachoem, @channainfo we can try as Thea mentioned to modify in these 3 classes:

• Promotion::Actions::CreateAdjustment
• Promotion::Actions::CreateItemAdjustments
• Promotion::Actions::CreateDateSpecificItemAdjustments
  but this shall affected in other calculators.
  For example, Promotion::Actions::CreateAdjustment could have many calculators such as flat_rate, flexi_rate, shipping, tiered_percent.... If we override method calculate in this class, I'm not sure if it would be the right place.

[theachoem]

Look good to me bong, adding in calculator make more sense than my method if we want to cap each day.