Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): remove unused utils #1797

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Dec 15, 2023

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

  • 사용하지 않는 유틸 함수들을 제거합니다.
  • 마이너: tsconfig build 잘못된 경로 수정

Details

  • mergeClassName 함수는 classnames로 대체합니다.

Breaking change? (Yes/No)

No

@sungik-choi sungik-choi added the refactoring Issue or PR related to refactoring with no functional changes label Dec 15, 2023
@sungik-choi sungik-choi self-assigned this Dec 15, 2023
Copy link

changeset-bot bot commented Dec 15, 2023

⚠️ No Changeset found

Latest commit: 59f688b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1dafd8) 86.92% compared to head (59f688b) 87.12%.
Report is 1 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #1797      +/-   ##
==========================================
+ Coverage   86.92%   87.12%   +0.20%     
==========================================
  Files         277      277              
  Lines        3831     3798      -33     
  Branches      802      794       -8     
==========================================
- Hits         3330     3309      -21     
+ Misses        428      416      -12     
  Partials       73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi merged commit 3e1ecae into channel-io:alpha Dec 15, 2023
6 checks passed
@sungik-choi sungik-choi deleted the chore/rm-unused-utils branch December 15, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Issue or PR related to refactoring with no functional changes
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants