Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unsupported healthCheckEndpoint config #362

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: Remove unsupported healthCheckEndpoint config #362

merged 1 commit into from
Jan 17, 2025

Conversation

jfoo1984
Copy link
Collaborator

@jfoo1984 jfoo1984 commented Jan 17, 2025 •
edited
Loading

healthCheckEndpoint is not supposed in our version of graphql mesh

including it in config actually causes a warning when running mesh build

> mesh build

🕸️  Mesh 💡 Cleaning existing artifacts
🕸️  Mesh 💡 Reading the configuration
🕸️  Mesh - config ⚠️ Configuration file is not valid!
🕸️  Mesh - config ⚠️ This is just a warning! It doesn't have any effects on runtime.
🕸️  Mesh - config ⚠️ Error: must NOT have additional properties
🕸️  Mesh 💡 Generating the unified schema

@jfoo1984 jfoo1984 requested review from bchu1 and rzlim08 January 17, 2025 01:44
@jfoo1984 jfoo1984 changed the title Remove unsupported healthCheckEndpoint config fix: Remove unsupported healthCheckEndpoint config Jan 17, 2025
@jfoo1984 jfoo1984 enabled auto-merge (squash) January 17, 2025 01:47
@jfoo1984 jfoo1984 merged commit 9515835 into main Jan 17, 2025
5 of 7 checks passed
@jfoo1984 jfoo1984 deleted the jfu/remove-healthcheckendpoint-config branch January 17, 2025 17:14
@czi-github-helper czi-github-helper bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzlim08 rzlim08 rzlim08 approved these changes

@bchu1 bchu1 Awaiting requested review from bchu1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfoo1984 @rzlim08