tidy

chanzuckerberg · Apr 25, 2024 · 304b06f · 304b06f
1 parent a3e8b56
commit 304b06f
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 20 deletions.
diff --git a/config/v2/config.go b/config/v2/config.go
@@ -260,13 +260,11 @@ type KubernetesProvider struct {
 }
 
 type HelmProvider struct {
-	CommonProvider       `yaml:",inline"`
-	ClusterComponentName *string `yaml:"cluster_component_name,omitempty"`
+	CommonProvider `yaml:",inline"`
 }
 
 type KubectlProvider struct {
-	CommonProvider       `yaml:",inline"`
-	ClusterComponentName *string `yaml:"cluster_component_name,omitempty"`
+	CommonProvider `yaml:",inline"`
 }
 
 // Backend is used to configure a terraform backend

diff --git a/config/v2/resolvers.go b/config/v2/resolvers.go
@@ -659,10 +659,8 @@ func ResolveHelmProvider(commons ...Common) *HelmProvider {
 			}
 		}
 	}
-	clusterComponentName := lastNonNil(KubernetesProviderClusterComponentNameGetter, commons...)
 	if version != nil {
 		return &HelmProvider{
-			ClusterComponentName: clusterComponentName,
 			CommonProvider: CommonProvider{
 				CustomProvider: lastNonNilBool(HelmProviderCustomProviderGetter, commons...),
 				Enabled:        enabled,
@@ -701,10 +699,8 @@ func ResolveKubectlProvider(commons ...Common) *KubectlProvider {
 		}
 	}
 
-	clusterComponentName := lastNonNil(KubernetesProviderClusterComponentNameGetter, commons...)
 	if version != nil {
 		return &KubectlProvider{
-			ClusterComponentName: clusterComponentName,
 			CommonProvider: CommonProvider{
 				CustomProvider: lastNonNilBool(KubectlProviderCustomProviderGetter, commons...),
 				Enabled:        enabled,

diff --git a/templates/templates/common/kubernetes_provider.tmpl b/templates/templates/common/kubernetes_provider.tmpl
@@ -1,16 +1,19 @@
 {{ define "kubernetes_provider" -}}
-{{ if .ClusterComponentName -}}
+{{ if .Kubernetes.ClusterComponentName -}}
   data "aws_eks_cluster" "cluster" {
-    name = data.terraform_remote_state.{{ .ClusterComponentName }}.outputs.cluster_id
+    name = data.terraform_remote_state.{{ .Kubernetes.ClusterComponentName }}.outputs.cluster_id
   }
 
   data "aws_eks_cluster_auth" "cluster" {
-    name = data.terraform_remote_state.{{ .ClusterComponentName }}.outputs.cluster_id
+    name = data.terraform_remote_state.{{ .Kubernetes.ClusterComponentName }}.outputs.cluster_id
   }
 
 provider "kubernetes" {
   host                   = data.aws_eks_cluster.cluster.endpoint
   cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
   token                  = data.aws_eks_cluster_auth.cluster.token
 }
+
+{{template "helm_provider" .Helm -}}
+{{- template "kubectl_provider" .Kubectl -}}
 {{ end }}{{ end }}
diff --git a/templates/templates/component/terraform/fogg.tf.tmpl b/templates/templates/component/terraform/fogg.tf.tmpl
@@ -77,15 +77,7 @@ variable "TFC_PROJECT_NAME" {
 {{ end }}{{ end }}
 
 {{- if .ProviderConfiguration.Kubernetes -}}{{- if not .ProviderConfiguration.Kubernetes.CustomProvider -}}
-  {{- template "kubernetes_provider" .ProviderConfiguration.Kubernetes -}}
-{{- end -}}{{- end -}}
-
-{{- if .ProviderConfiguration.Helm -}}{{- if not .ProviderConfiguration.Helm.CustomProvider -}}
-  {{- template "helm_provider" .ProviderConfiguration.Helm -}}
-{{- end -}}{{- end -}}
-
-{{- if .ProviderConfiguration.Kubectl -}}{{- if not .ProviderConfiguration.Kubectl.CustomProvider -}}
-  {{- template "kubectl_provider" .ProviderConfiguration.Kubectl -}}
+  {{- template "kubernetes_provider" .ProviderConfiguration -}}
 {{- end -}}{{- end -}}
 
 terraform {