fix: add func for git origin (#931)

* fix: add func for git origin

* move test; deadcode

* timestamp

apply/apply.go

@@ -8,6 +8,7 @@ import (
 	"io/fs"
 	"net/url"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"regexp"
 	"sort"
@@ -522,6 +523,21 @@ func removeExtension(path string) string {
 	return strings.TrimSuffix(path, filepath.Ext(path))
 }
 
+func getGitRemoteOriginURL(cwd ...string) string {
+	dir := "."
+	if len(cwd) > 0 {
+		dir = cwd[0]
+	}
+	cmd := exec.Command("git", "remote", "get-url", "--push", "origin")
+	cmd.Dir = dir
+	out, err := cmd.Output()
+	if err != nil {
+		logrus.Warnf("unable to get git output: %s", err)
+		return ""
+	}
+	return strings.TrimSpace(string(out))
+}
+
 func applyTemplate(sourceFile io.Reader, commonTemplates fs.FS, dest afero.Fs, path string, overrides interface{}) error {
 	dir := filepath.Dir(path)
 	err := dest.MkdirAll(dir, 0775)
@@ -539,6 +555,7 @@ func applyTemplate(sourceFile io.Reader, commonTemplates fs.FS, dest afero.Fs, p
 			"cwd": func() string {
 				return filepath.Dir(writer.Name())
 			},
+			"git_origin": getGitRemoteOriginURL,
 		},
 	}...)
 	if e != nil {

apply/apply_test.go

@@ -29,6 +29,22 @@ func init() {
 	logrus.SetFormatter(formatter)
 }
 
+type testGitRemote struct {
+	path           string
+	expectedRemote string
+}
+
+func TestGetGitRemoveOriginURL(t *testing.T) {
+	r := require.New(t)
+	tests := []testGitRemote{
+		{path: ".", expectedRemote: "[email protected]:chanzuckerberg/fogg"},
+	}
+	for _, test := range tests {
+		remote := getGitRemoteOriginURL(test.path)
+		r.Equal(test.expectedRemote, remote)
+	}
+}
+
 func randomString(n int) string {
 	var letter = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789")
 

config/v2/config.go

@@ -4,14 +4,12 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"os/exec"
 	"path/filepath"
 	"strings"
 	"time"
 
 	"github.com/chanzuckerberg/fogg/errs"
 	"github.com/chanzuckerberg/fogg/plugins"
-	"github.com/sirupsen/logrus"
 	"github.com/spf13/afero"
 	yaml "gopkg.in/yaml.v3"
 )
@@ -54,28 +52,10 @@ func (c *Config) Write(fs afero.Fs, path string) error {
 	return encoder.Encode(c)
 }
 
-func getGitRemoteOriginURL(cwd ...string) string {
-	dir := "."
-	if len(cwd) > 0 {
-		dir = cwd[0]
-	}
-	cmd := exec.Command("git", "remote", "get-url", "--push", "origin")
-	cmd.Dir = dir
-	out, err := cmd.Output()
-	if err != nil {
-		logrus.Warnf("unable to get git output: %s", err)
-		return ""
-	}
-	return strings.TrimSpace(string(out))
-}
-
 // TODO: write out functions to generate tag data
 func (c *Config) GenerateStamp(fs afero.Fs, configFile string) {
 	stamp := Stamp{}
-	stamp.Date = DateAsTag()
 	stamp.FoggUser = ""
-	stamp.GitRepository = getGitRemoteOriginURL()
-	stamp.CommitHash = ""
 	c.Stamp = stamp
 }
 
@@ -86,10 +66,7 @@ func DateAsTag() string {
 }
 
 type Stamp struct {
-	Date          string
-	FoggUser      string
-	GitRepository string
-	CommitHash    string
+	FoggUser string
 }
 
 type Config struct {

config/v2/config_test.go

@@ -8,22 +8,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-type testGitRemote struct {
-	path           string
-	expectedRemote string
-}
-
-func TestGetGitRemoveOriginURL(t *testing.T) {
-	r := require.New(t)
-	tests := []testGitRemote{
-		{path: ".", expectedRemote: "[email protected]:chanzuckerberg/fogg"},
-	}
-	for _, test := range tests {
-		remote := getGitRemoteOriginURL(test.path)
-		r.Equal(test.expectedRemote, remote)
-	}
-}
-
 func TestReadConfig(t *testing.T) {
 	r := require.New(t)
 

plan/plan.go

@@ -1287,10 +1287,7 @@ func resolveComponentCommon(stamp v2.Stamp, commons ...v2.Common) ComponentCommo
 		TravisCI:         travisPlan,
 		CircleCI:         circlePlan,
 		GitHubActionsCI:  githubActionsPlan,
-		Date:             stamp.Date,
 		FoggUser:         stamp.FoggUser,
-		GitRepository:    stamp.GitRepository,
-		CommitHash:       stamp.CommitHash,
 	}
 }
 

templates/templates/component/terraform/fogg.tf.tmpl

@@ -127,11 +127,10 @@ variable "tags" {
     env                   = "{{ .Env }}"
     service               = "{{ .Name }}"
     owner                 = "{{ .Owner }}"
-    date                  = "{{ .Date }}"
+    terraformLastApplyTime = timestamp()
     terraformWorkspaceDir = "{{ cwd }}"
     foggUser              = "{{ .FoggUser }}"
-    gitRepository         = "{{ .GitRepository }}"
-    commitHash            = "{{ .CommitHash }}"
+    gitRepository         = "{{ git_origin }}"
     managedBy             = "terraform"
   }
 }