Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellxgene-schema CLI is not correctly enforcing obs['is_primary_data'] #1076

Open
brianraymor opened this issue Oct 30, 2024 · 1 comment
Open
Labels
bug Something isn't working curation software dp Data Platform Team work

Comments

@brianraymor
Copy link
Contributor

Context

Reported by @jahilton. See #sci-data-eng.

@brianraymor brianraymor added bug Something isn't working curation software dp Data Platform Team work labels Oct 30, 2024
@nayib-jose-gloria
Copy link
Contributor

The issue here is that we currently accept both bool and numpy.bool types for 'is_single'. However, our validation check for is_primary_data checks against "is False" which only works as expected for bool.

These datasets used numpy.bool and thus unexpectedly passed by evaluating "numpy.bool(False) is False" as False instead of True.

The solution is to either update this check (and others) to account for numpy.bool OR enforce that we do not accept numpy.bool types. Probably easiest to just account for numpy._bool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working curation software dp Data Platform Team work
Projects
None yet
Development

No branches or pull requests

2 participants