Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schema 5.3 #7428

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: schema 5.3 #7428

wants to merge 7 commits into from

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Feb 6, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Deployment Summary

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 95.14925% with 13 lines in your changes missing coverage. Please review.

Project coverage is 92.87%. Comparing base (f0bd1ee) to head (e0887f0).

Files with missing lines Patch % Lines
backend/layers/business/exceptions.py 40.00% 3 Missing ⚠️
backend/layers/business/business.py 71.42% 2 Missing ⚠️
backend/layers/processing/process.py 50.00% 2 Missing ⚠️
backend/layers/processing/process_logic.py 0.00% 2 Missing ⚠️
backend/layers/processing/process_validate.py 94.28% 2 Missing ⚠️
...nd/layers/processing/utils/cxg_generation_utils.py 96.00% 1 Missing ⚠️
...end/layers/thirdparty/schema_validator_provider.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7428      +/-   ##
==========================================
- Coverage   92.91%   92.87%   -0.05%     
==========================================
  Files         194      193       -1     
  Lines       16831    16496     -335     
==========================================
- Hits        15638    15320     -318     
+ Misses       1193     1176      -17     
Flag Coverage Δ
unittests 92.87% <95.14%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

r"(?<!\.-$)" # Bucket name must not end with a period followed by a hyphen
r"(?<!\.$)" # Bucket name must not end with a period
r"(?<!-$)" # Bucket name must not end with a hyphen
r"(/([a-zA-Z0-9._-]+/?)*)?$" # key naming constraints

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 's3://0-0/' and containing many repetitions of '-'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants