-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PUT for manifest files #7431
Conversation
Deployment Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/schema-5-3 #7431 +/- ##
=====================================================
Coverage ? 92.99%
=====================================================
Files ? 194
Lines ? 16539
Branches ? 0
=====================================================
Hits ? 15380
Misses ? 1159
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise it looks good.
...d/curation/api/v1/curation/collections/collection_id/datasets/dataset_id/manifest/actions.py
Show resolved
Hide resolved
Co-authored-by: Trent Smith <[email protected]>
Reason for Change
TODO
[ ] Submit ATAC to SFNI think it would be better if
ingest_dataset
ONLY took a manifest, and that the routing layer above it had to account for transforming the JSON. But the method is called in really a lot of tests, so changing it would touch a lot of code.Changes
Testing steps
Checklist 🛎️
Notes for Reviewer