Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PUT for manifest files #7431

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Conversation

ivirshup
Copy link
Contributor

@ivirshup ivirshup commented Feb 11, 2025

Reason for Change

TODO

  • Tests
    • Test submission of dataset with ATAC fragments
    • Fill out tests for errors at new endpoint
  • Features
    • [ ] Submit ATAC to SFN
  • Open questions
    • Do we need to handle file sizes for ATAC fragments? No

I think it would be better if ingest_dataset ONLY took a manifest, and that the routing layer above it had to account for transforming the JSON. But the method is called in really a lot of tests, so changing it would touch a lot of code.

Changes

  • Added a PUT endpoint for manifest files

Testing steps

Checklist 🛎️

Notes for Reviewer

Copy link
Contributor

Deployment Summary

@ivirshup ivirshup changed the base branch from main to feature/schema-5-3 February 11, 2025 00:33
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 87.20930% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/schema-5-3@07a6435). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...lection_id/datasets/dataset_id/manifest/actions.py 66.66% 9 Missing ⚠️
backend/layers/business/business.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feature/schema-5-3    #7431   +/-   ##
=====================================================
  Coverage                      ?   92.99%           
=====================================================
  Files                         ?      194           
  Lines                         ?    16539           
  Branches                      ?        0           
=====================================================
  Hits                          ?    15380           
  Misses                        ?     1159           
  Partials                      ?        0           
Flag Coverage Δ
unittests 92.99% <87.20%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivirshup ivirshup changed the title FEAT: PUT for manifest files feat: PUT for manifest files Feb 11, 2025
@ivirshup ivirshup marked this pull request as ready for review February 11, 2025 21:30
@ivirshup ivirshup requested a review from Bento007 February 11, 2025 21:30
Copy link
Contributor

@Bento007 Bento007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise it looks good.

@ivirshup ivirshup merged commit de911dc into feature/schema-5-3 Feb 11, 2025
22 of 23 checks passed
@ivirshup ivirshup deleted the ivirshup/put-manifest branch February 11, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants