Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEM example with a particle discharge from a plate with ASC and LB #1191

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

acdaigneault
Copy link
Collaborator

@acdaigneault acdaigneault commented Jul 8, 2024

Description

The example is a simple case of particle discharging from a plate that compares the computational performance and the angle of repose of simulations using the Adaptive Sparse Contacts, the dynamic Load Balancing and both of them from a baseline simulation.
The simulations have 52000 particles and run under 45 minutes each.
This is the first example describing the ASC method.

Miscellaneous (will be removed when merged)

I will have to rebase to master after the example of Cleo is merged because of the conflicts in the .rst DEM exemples page.

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • Links are added to parent .rst files
  • The example is following the standard format

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planed, an issue is opened
  • The PR description is cleaned and ready for merge

@acdaigneault acdaigneault added Needs more reviewers This pull request needs more review before a merge is possible Example labels Jul 8, 2024
@acdaigneault acdaigneault added Ready for review and removed Needs more reviewers This pull request needs more review before a merge is possible labels Jul 8, 2024
Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one file left. I will look at it this PM

Copy link
Collaborator

@hepap hepap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have review the .rst. I will complete my review tomorrow :)

Really nice example!

Copy link
Collaborator

@oguevremont oguevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have no major comment

@blaisb
Copy link
Contributor

blaisb commented Jul 10, 2024

Personally I don't have additional comments atop the already good ones that have been posted here.

Copy link
Collaborator

@AmishgaAlphonius AmishgaAlphonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! And amazing figures!! I have a few minor comments :)

Copy link
Contributor

@blaisb blaisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just wait for the last comments to be addressed and the ok from @hepap. Once those are OK, you can add the reviewed and ready to merge label :)

Copy link
Collaborator

@hepap hepap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

@acdaigneault
Copy link
Collaborator Author

I think I adressed all comments, thank you guys :)

@blaisb blaisb merged commit 26d8692 into master Jul 17, 2024
3 checks passed
@blaisb blaisb deleted the example-DEM-ASC branch July 17, 2024 17:18
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
…haos-polymtl#1191)

Description
The example is a simple case of particle discharging from a plate that compares the computational performance and the angle of repose of simulations using the Adaptive Sparse Contacts, the dynamic Load Balancing and both of them from a baseline simulation.
The simulations have 52000 particles and run under 45 minutes each.
This is the first example describing the ASC method.

Co-authored-by: Olivier Guévremont <[email protected]>
Co-authored-by: hepap <[email protected]>

Former-commit-id: 26d8692
blaisb pushed a commit that referenced this pull request Sep 30, 2024
…1191)

Description
The example is a simple case of particle discharging from a plate that compares the computational performance and the angle of repose of simulations using the Adaptive Sparse Contacts, the dynamic Load Balancing and both of them from a baseline simulation.
The simulations have 52000 particles and run under 45 minutes each.
This is the first example describing the ASC method.

Co-authored-by: Olivier Guévremont <[email protected]>
Co-authored-by: hepap <[email protected]>

Former-commit-id: 26d8692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants