Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS: add release notes for pdsh-2.35 #155

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

grondo
Copy link
Member

@grondo grondo commented Dec 19, 2023

Problem: There are no release notes for pdsh-2.35.

Add release notes to the NEWS file.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0ef614) 64.67% compared to head (e9fc881) 64.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   64.67%   64.70%   +0.03%     
==========================================
  Files          27       27              
  Lines        5947     5947              
==========================================
+ Hits         3846     3848       +2     
+ Misses       2101     2099       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one (probable) typo.

NEWS Outdated
-- slurm: fix compile of slurm plugin against Slurm >= 23.x
-- log module option errors with -d (Erik Jacobson)
-- fail fast on connect error or non-zero return code (Jerry Mannil)
-- release a lock that is no longer user (ycaibb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "no longer used" was meant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed that and will set MWP.

Problem: There are no release notes for pdsh-2.35.

Add release notes to the NEWS file.
@grondo grondo added the merge-when-passing Let mergify auto-rebase and merge when CI passes label Dec 19, 2023
@mergify mergify bot merged commit 64a7d37 into chaos:master Dec 19, 2023
8 checks passed
@grondo grondo deleted the news-2.35 branch December 19, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing Let mergify auto-rebase and merge when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants