Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an extra Step to choose Scratch Option. #110

Merged
merged 8 commits into from
May 2, 2024
Merged

Adding an extra Step to choose Scratch Option. #110

merged 8 commits into from
May 2, 2024

Conversation

ise8933
Copy link
Contributor

@ise8933 ise8933 commented Apr 30, 2024 •
edited
Loading

This PR...

Changes

-SETUP.md

Screenshots

image

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Fixes #

@ise8933
Update SETUP.md
56aeb83 
Signed-off-by: Isha Errande <[email protected]>
@ise8933
Update SETUP.md
4e622bd 
Signed-off-by: Isha Errande <[email protected]>
@ise8933
Update SETUP.md
06eb8f0 
Signed-off-by: Isha Errande <[email protected]>
@ise8933
Update SETUP.md
02200b5 
Signed-off-by: Isha Errande <[email protected]>
@ise8933
Update SETUP.md
0bedb6a 
Signed-off-by: Isha Errande <[email protected]>
@ise8933
Update SETUP.md
b77af8c 
Signed-off-by: Isha Errande <[email protected]>
@ise8933
Update SETUP.md
990c2f0 
Signed-off-by: Isha Errande <[email protected]>
@ise8933
Copy link
Contributor Author

ise8933 commented Apr 30, 2024

This is my initial pull request after fulfilling the basic requirements of adding an extra step. While setting up, there are some other things I noticed the setup doc needed such as more images, etc. I will commit these additional changes to this pull request when I get the chance. Let me know if there are any issues!

@ise8933
Update SETUP.md
59d44c9 
Added more images under setting up events, 

Signed-off-by: Isha Errande <[email protected]>
@misspee007 misspee007 changed the base branch from main to staging May 1, 2024 20:55
@misspee007 misspee007 linked an issue May 1, 2024 that may be closed by this pull request
[Docs]: A skipped step in Setup.md on installing a slack app #101
Closed
1 task
@misspee007
Copy link
Collaborator

This is my initial pull request after fulfilling the basic requirements of adding an extra step. While setting up, there are some other things I noticed the setup doc needed such as more images, etc. I will commit these additional changes to this pull request when I get the chance. Let me know if there are any issues!

Hey, this is great! Can I merge this now, or are you still making changes?

@ise8933
Copy link
Contributor Author

ise8933 commented May 1, 2024

Hi I finished adding the changes you can merge it! Thanks

@misspee007 misspee007 merged commit bc43ea2 into chaoss:staging May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs]: A skipped step in Setup.md on installing a slack app
2 participants
@ise8933 @misspee007