[api] Change task_id type to ID and cast interval to Int #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `task_id` fields in `DeleteScheduledTask` and `UpdateScheduledTask` to use `graphene.ID()` instead of `graphene.Int()`. In Graphene v3, this was causing type errors because a string value was being passed instead of an integer. Also converted interval values to numbers in the ImporterModal and SettingsGeneral components to prevent similar type errors, since Graphene v3 expects numeric values instead of strings. Signed-off-by: Jose Javier Merchante <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
task_idfields inDeleteScheduledTaskandUpdateScheduledTaskto usegraphene.ID()instead ofgraphene.Int(). In Graphene v3, this was causing type errors because a string value was being passed instead of an integer.Also converted
intervalvalues to numbers in theImporterModalandSettingsGeneralcomponents to prevent similar type errors, since Graphene v3 expects numeric values instead of strings.