Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awslambda put_function_env functionality #82

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

awslambda put_function_env functionality #82

wants to merge 1 commit into from

Conversation

simontabor
Copy link

Signed-off-by: Simon Tabor [email protected]

Simple functionality to allow setting environment variables within Lambdas, which we're going to use to configure some application chaos experiments

Lawouach
Lawouach requested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@Lawouach Lawouach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks good :)

Could you:

  • add a couple of tests?
  • add a changelog entry?

Notice, a couple of PRs will be merged in soon so this may need a few rebase :/

@Lawouach Lawouach marked this pull request as draft June 11, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lawouach Lawouach Lawouach requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simontabor @Lawouach