don't leave before visiting all nodes

Signed-off-by: Sylvain Hellegouarch <[email protected]>
chaostoolkit · Nov 13, 2023 · 35d2c39 · 35d2c39
1 parent baef432
commit 35d2c39
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,15 @@
 
 ## [Unreleased][]
 
-[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-kubernetes/compare/0.34.0...HEAD
+[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-kubernetes/compare/0.34.1...HEAD
+
+## [0.34.1][] - 2023-11-13
+
+[0.34.1]: https://github.com/chaostoolkit/chaostoolkit-kubernetes/compare/0.34.0...0.34.1
+
+### Fixed
+
+* Don't escape node draining too soon
 
 ## [0.34.0][] - 2023-11-13
 

diff --git a/chaosk8s/node/actions.py b/chaosk8s/node/actions.py
@@ -348,8 +348,8 @@ def drain_nodes(
                 )
 
         if not eviction_candidates:
-            logger.debug("No pods to evict. Let's return.")
-            return True
+            logger.debug("No pods to evict. Let's move on to the next node.")
+            continue
 
         logger.debug(f"Found {len(eviction_candidates)} pods to evict")
         for pod in eviction_candidates: