Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unavailable replicas calculation #113

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jfillatre
Copy link

No description provided.

@jfillatre jfillatre force-pushed the fix-statefulset-fully-available-no-attribut branch from 97616fc to 8a7ffb1 Compare December 29, 2020 15:03
@jfillatre
Copy link
Author

Proposal for #112 issue

@Lawouach
Copy link
Contributor

Hello,

Looks like a good idea. I wonder if the meaning of unavailable only means unready though? Could we find anything in the Kubernetes spec/code that clarifies this?

@jfillatre
Copy link
Author

jfillatre commented Feb 27, 2021

Indeed unavailable_replicas is a deployment status property. May be the best is to remove this information from log

@codecov-io
Copy link

codecov-io commented Feb 27, 2021

Codecov Report

Merging #113 (96d1db7) into master (4dbb88a) will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   79.33%   80.40%   +1.06%     
==========================================
  Files          14       17       +3     
  Lines         818      939     +121     
==========================================
+ Hits          649      755     +106     
- Misses        169      184      +15     
Impacted Files Coverage Δ
chaosk8s/statefulset/probes.py 95.12% <ø> (ø)
chaosk8s/actions.py 80.95% <0.00%> (ø)
chaosk8s/probes.py 100.00% <0.00%> (ø)
chaosk8s/__init__.py 85.13% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbb88a...96d1db7. Read the comment docs.

@Lawouach Lawouach marked this pull request as draft September 11, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants