Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework and clean up modules #40

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Devatoria
Copy link
Contributor

@Devatoria Devatoria commented Jun 6, 2019

This PR is related to issue #39

  • scope actions and probes
  • (re)write actions and probes tests

Signed-off-by: Devatoria <[email protected]>
Signed-off-by: Devatoria <[email protected]>
@Lawouach
Copy link
Contributor

Lawouach commented Jun 6, 2019

You are awesome @Devatoria ! :)

@Lawouach Lawouach added the needs-changes Waiting for PR changes label Dec 1, 2019
@tdevilleduc
Copy link
Contributor

Is there something to improve here ?
I was thinking about moving all functions from chaosk8s/probes.py to differents folders:

  • deployment_is_not_fully_available, deployment_is_fully_available, microservice_available_and_healthy, and microservice_is_not_available to deployment/probes.py
  • service_endpoint_is_initialized to service/probes.py
  • I don't know about all_microservices_healthy

Should I commit directly on @Devatoria repository ?

@Lawouach
Copy link
Contributor

I think moving things around is a good idea.

Maybe keeping existing modules with the functiin linking to the appropriate ones but with a warning when they are used from there?

Also, the whole business of "microservice" was a stupidity of mine, it's just a top-down deployment to pod set of functions. Should they remain that way?

@tdevilleduc
Copy link
Contributor

I've created a pull request to DataDog repository
Let's hope he will find it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-changes Waiting for PR changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants