fix: changed how we extract major.minor from pandoc semver as they do… #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt always use a full major.minor.patch semver and we just throw away anything after minor anyway. Signed-off-by: Chris Doyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #48 reports a failure in CTK-reporting when it tries to extract the
majorandminorversions from the pandoc semver string. The issue is that not all releases have the semver pattern ofmajor.minor.patch. As a result if you are running pandoc latest realease version3.5then CTK-reporing will fail as there are not enough values to unpack since there is no patch part to the semver version.This fix changed how we extract and instead just unpacks major and minor into variables using a slice. This should be fine as we were just throwing away the rest of the semver string anyway.