-
Notifications
You must be signed in to change notification settings - Fork 423
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix bugs with 32 bit types being passed to
gpuScan
(#24600)
There were failures in `gpu-sort-performance-explorer` caused by in in-house radix sort using the `gpuScan` which was untested for `uint(32)` types. Upon testing it was revealed that passing any type which is not a 64 bit type caused an error as seen in #24602 This PR fixes `gpuScan` to work with no 64 bit types by using the workaround described in issue above. Why this works is not known yet :) While there, we also expand the `gpuScan` testing and cleanup some code. [Reviewed by @vasslitvinov]
- Loading branch information
Showing
7 changed files
with
34 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
internal error: gpu-nvidia.c:292: Error calling CUDA function: misaligned address (Code: 716) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
on here.gpus[0] { | ||
var a: [1..10] uint(32); | ||
@assertOnGpu | ||
foreach chunk in 0..1 { | ||
serialScan(a); // Exclusive scan in serial | ||
} | ||
} | ||
|
||
proc serialScan(ref arr : [] uint(32)) { | ||
// Calculate the prefix sum | ||
var sum : uint(32); | ||
var temp : uint(32) = arr[1]; | ||
arr[1] = sum; | ||
sum += temp; | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# issue: |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters