Skip to content

Commit

Permalink
account for nondeterminism
Browse files Browse the repository at this point in the history
---
Signed-off-by: Andy Stone <[email protected]>
  • Loading branch information
stonea committed Jul 1, 2024
1 parent 41d4cff commit 4e48dd0
Show file tree
Hide file tree
Showing 12 changed files with 23 additions and 138 deletions.
2 changes: 1 addition & 1 deletion test/library/packages/ConcurrentMap/memLeakTests/PREDIFF
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash

sed -E "s/0x[0-9a-f]*/prediffed/" <$2 >$2.predifftmp
grep -v "\.chpl:.*" < $2 >$2.predifftmp
mv $2.predifftmp $2
4 changes: 0 additions & 4 deletions test/library/packages/ConcurrentMap/memLeakTests/README
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
This directory is locking down that we currently have a memory leak for
ConcurrentMap. These tests symlink to equivalent correctness tests and can be
removed once this leak is fixed.

We only symlink to the a subset of these tests where the
allocations/deallocations are deterministic (this should be sufficient for
memory tracking purposes).
17 changes: 0 additions & 17 deletions test/library/packages/ConcurrentMap/memLeakTests/testAddSet.good
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,5 @@
================================================= Memory Leaks ==================================================
Allocated Memory (Bytes) Number Size Total Description Address
=================================================================================================================
testAddSet.chpl:5 1 160 160 Bucket(int(64),int(64)) prediffed
testAddSet.chpl:3 1 88 88 Buckets(int(64),int(64)) prediffed
testAddSet.chpl:3 1 128 128 [domain(1,int(64),one)] AtomicObject(unmanaged Base(int(64),int(64))?,false,true)prediffed
testAddSet.chpl:3 1 24 24 _token prediffed
testAddSet.chpl:3 1 24 24 _token prediffed
testAddSet.chpl:3 1 24 24 _token prediffed
testAddSet.chpl:3 1 24 24 _token prediffed
testAddSet.chpl:3 1 24 24 _token prediffed
testAddSet.chpl:3 1 24 24 _token prediffed
testAddSet.chpl:32 1 24 24 _token prediffed
testAddSet.chpl:32 1 24 24 _token prediffed
testAddSet.chpl:32 1 24 24 _token prediffed
testAddSet.chpl:32 1 24 24 _token prediffed
testAddSet.chpl:32 1 24 24 _token prediffed
testAddSet.chpl:32 1 24 24 _token prediffed
testAddSet.chpl:3 1024 8 8192 array elements prediffed
testAddSet.chpl:3 1 72 72 domain(1,int(64),one) prediffed
=================================================================================================================

16 changes: 0 additions & 16 deletions test/library/packages/ConcurrentMap/memLeakTests/testClear.good
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,5 @@
================================================= Memory Leaks ==================================================
Allocated Memory (Bytes) Number Size Total Description Address
=================================================================================================================
testClear.chpl:4 1 88 88 Buckets(string,int(64)) prediffed
testClear.chpl:4 1 128 128 [domain(1,int(64),one)] AtomicObject(unmanaged Base(string,int(64))?,false,true)prediffed
testClear.chpl:4 1 24 24 _token prediffed
testClear.chpl:4 1 24 24 _token prediffed
testClear.chpl:4 1 24 24 _token prediffed
testClear.chpl:4 1 24 24 _token prediffed
testClear.chpl:4 1 24 24 _token prediffed
testClear.chpl:4 1 24 24 _token prediffed
testClear.chpl:12 1 24 24 _token prediffed
testClear.chpl:12 1 24 24 _token prediffed
testClear.chpl:12 1 24 24 _token prediffed
testClear.chpl:12 1 24 24 _token prediffed
testClear.chpl:12 1 24 24 _token prediffed
testClear.chpl:12 1 24 24 _token prediffed
testClear.chpl:4 1024 8 8192 array elements prediffed
testClear.chpl:4 1 72 72 domain(1,int(64),one) prediffed
=================================================================================================================

76 changes: 0 additions & 76 deletions test/library/packages/ConcurrentMap/memLeakTests/testEquality.good
Original file line number Diff line number Diff line change
Expand Up @@ -6,81 +6,5 @@ true
================================================= Memory Leaks ==================================================
Allocated Memory (Bytes) Number Size Total Description Address
=================================================================================================================
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:9 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:10 1 160 160 Bucket(int(64),int(64)) prediffed
testEquality.chpl:3 1 88 88 Buckets(int(64),int(64)) prediffed
testEquality.chpl:4 1 88 88 Buckets(int(64),int(64)) prediffed
testEquality.chpl:3 1 128 128 [domain(1,int(64),one)] AtomicObject(unmanaged Base(int(64),int(64))?,false,true)prediffed
testEquality.chpl:4 1 128 128 [domain(1,int(64),one)] AtomicObject(unmanaged Base(int(64),int(64))?,false,true)prediffed
testEquality.chpl:3 1 24 24 _token prediffed
testEquality.chpl:3 1 24 24 _token prediffed
testEquality.chpl:3 1 24 24 _token prediffed
testEquality.chpl:3 1 24 24 _token prediffed
testEquality.chpl:3 1 24 24 _token prediffed
testEquality.chpl:3 1 24 24 _token prediffed
testEquality.chpl:4 1 24 24 _token prediffed
testEquality.chpl:4 1 24 24 _token prediffed
testEquality.chpl:4 1 24 24 _token prediffed
testEquality.chpl:4 1 24 24 _token prediffed
testEquality.chpl:4 1 24 24 _token prediffed
testEquality.chpl:4 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:13 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:14 1 24 24 _token prediffed
testEquality.chpl:19 1 24 24 _token prediffed
testEquality.chpl:19 1 24 24 _token prediffed
testEquality.chpl:19 1 24 24 _token prediffed
testEquality.chpl:19 1 24 24 _token prediffed
testEquality.chpl:19 1 24 24 _token prediffed
testEquality.chpl:19 1 24 24 _token prediffed
testEquality.chpl:20 1 24 24 _token prediffed
testEquality.chpl:20 1 24 24 _token prediffed
testEquality.chpl:20 1 24 24 _token prediffed
testEquality.chpl:20 1 24 24 _token prediffed
testEquality.chpl:20 1 24 24 _token prediffed
testEquality.chpl:20 1 24 24 _token prediffed
testEquality.chpl:3 1024 8 8192 array elements prediffed
testEquality.chpl:4 1024 8 8192 array elements prediffed
testEquality.chpl:3 1 72 72 domain(1,int(64),one) prediffed
testEquality.chpl:4 1 72 72 domain(1,int(64),one) prediffed
=================================================================================================================

Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,5 @@
================================================= Memory Leaks ==================================================
Allocated Memory (Bytes) Number Size Total Description Address
=================================================================================================================
testGetRemove.chpl:11 1 416 416 Bucket(string,int(64)) prediffed
testGetRemove.chpl:7 1 88 88 Buckets(string,int(64)) prediffed
testGetRemove.chpl:7 1 128 128 [domain(1,int(64),one)] AtomicObject(unmanaged Base(string,int(64))?,false,true)prediffed
testGetRemove.chpl:7 1 24 24 _token prediffed
testGetRemove.chpl:7 1 24 24 _token prediffed
testGetRemove.chpl:7 1 24 24 _token prediffed
testGetRemove.chpl:7 1 24 24 _token prediffed
testGetRemove.chpl:7 1 24 24 _token prediffed
testGetRemove.chpl:7 1 24 24 _token prediffed
testGetRemove.chpl:16 1 24 24 _token prediffed
testGetRemove.chpl:16 1 24 24 _token prediffed
testGetRemove.chpl:16 1 24 24 _token prediffed
testGetRemove.chpl:16 1 24 24 _token prediffed
testGetRemove.chpl:16 1 24 24 _token prediffed
testGetRemove.chpl:16 1 24 24 _token prediffed
testGetRemove.chpl:7 1024 8 8192 array elements prediffed
testGetRemove.chpl:7 1 72 72 domain(1,int(64),one) prediffed
testGetRemove.chpl:11 1 8 8 string copy data prediffed
=================================================================================================================

5 changes: 2 additions & 3 deletions test/library/packages/LockFreeQueue/PREDIFF
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/bin/bash

sed -E "s/0x[0-9a-f]*/prediffed/" <$2 >$2.predifftmp
grep prediffed $2.predifftmp | uniq -c >$2
rm $2.predifftmp
grep -v "\.chpl:.*" < $2 >$2.predifftmp
mv $2.predifftmp $2
3 changes: 3 additions & 0 deletions test/library/packages/LockFreeQueue/memLeaks/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
This directory is locking down that we currently have a memory leak for this
module. These tests symlink to equivalent correctness tests and can be removed
once this leak is fixed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

================================================= Memory Leaks ==================================================
Allocated Memory (Bytes) Number Size Total Description Address
=================================================================================================================
=================================================================================================================

5 changes: 2 additions & 3 deletions test/library/packages/LockFreeStack/PREDIFF
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/bin/bash

sed -E "s/0x[0-9a-f]*/prediffed/" <$2 >$2.predifftmp
grep prediffed $2.predifftmp | uniq -c >$2
rm $2.predifftmp
grep -v "\.chpl:.*" < $2 >$2.predifftmp
mv $2.predifftmp $2
3 changes: 3 additions & 0 deletions test/library/packages/LockFreeStack/memLeaks/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
This directory is locking down that we currently have a memory leak for this
module. These tests symlink to equivalent correctness tests and can be removed
once this leak is fixed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

================================================= Memory Leaks ==================================================
Allocated Memory (Bytes) Number Size Total Description Address
=================================================================================================================
=================================================================================================================

0 comments on commit 4e48dd0

Please sign in to comment.