-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chpldoc dependencies #24612
Merged
Merged
Update chpldoc dependencies #24612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mppf
commented
Mar 13, 2024
@@ -33,6 +33,7 @@ | |||
# ones. | |||
extensions = [ | |||
'sphinx.ext.todo', | |||
'sphinxcontrib.jquery', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the search box from sphinx-rtd-theme now uses jquery
b86a561
to
da53126
Compare
1 task
mppf
commented
Apr 5, 2024
mppf
added a commit
to chapel-lang/sphinxcontrib-chapeldomain
that referenced
this pull request
Apr 8, 2024
This is to go along with chapel-lang/chapel#24612 . The changes to test/test_chapeldomain.py avoid a problem when using docutils 0.19 or newer that came up with the way the test was using mocked objects. Reviewed by @lydia-duncan - thanks!
--- Signed-off-by: Michael Ferguson <[email protected]>
to avoid errors like .../compiler-internals/libraries.rst:11: WARNING: undefined label: 'LibraryFile_8h' --- Signed-off-by: Michael Ferguson <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
it was temporarily disabled in PR chapel-lang#24201 --- Signed-off-by: Michael Ferguson <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
The PREDIFF stopped working because newer Sphinx does not start the record with URL_ROOT. --- Signed-off-by: Michael Ferguson <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
lydia-duncan
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really really minor suggestions, thanks for running with this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the chpldoc requirements to the newest versions. I tried this because I was thinking about adjustment to the search box, and I wanted to see if the newer versions of Sphinx behave differently. (They do not seem to).
Sphinx 7.2.6 requires Python >= 3.9, so this PR updates prereqs.rst to list 3.9 as required for chpldoc, start_test, and c2chapel. (The previous requirement for these was Python 3.7).
It adds the sphinx extension
sphinxcontrib.jquery
toconf.py
because the search box from sphinx-rtd-theme now uses jquery.(note that chapel-lang/sphinxcontrib-chapeldomain#92 updated sphinxcontrib-chapeldomain in a coordinated manner: docutils 0.18 -> 0.20.1 and Sphinx 5.3.0 -> 7.2.6. The result of that PR is available in sphinxcontrib-chapeldomain version 0.0.32.)
Reviewed by @lydia-duncan - thanks!