Prevent chpl-language-server from providing type inserts for loops #25151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
|
A picture of the bug-to-be-fixed would help the PR OP. |
DanilaFe
approved these changes
May 31, 2024
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
force-pushed
the
fix-type-inlay-bug
branch
from
487ff37 to
7b16fce
Compare
DanilaFe
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
chpl-language-serverwould add insertable type inlays for loops, even though thats not valid syntax. If a user tried to insert the type inlay, they would then get a syntax error. This PR prevents users from making that mistake by removing the insertable inlay. The inlay still shows, it is just not insertable.Prior to this PR, users woild be able to insert the type as shown below
Inserting this type creates the following error
This PR prevents this situation from occurring all together.
Tested locally with
make test-cls[Reviewed by @DanilaFe]