Add a helper function to set up standard module paths #25326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on files_with_contexts to get contexts with stdlib. Signed-off-by: Danila Fedorin <[email protected]>
4 tasks
DanilaFe
force-pushed
the
files-with-contexts-setup
branch
from
ab43fa4 to
779d88a
Compare
riftEmber
added a commit
to riftEmber/chapel
that referenced
this pull request
Jun 20, 2024
From chapel-lang#25326 Signed-off-by: Anna Rift <[email protected]>
riftEmber
added a commit
to riftEmber/chapel
that referenced
this pull request
Jun 20, 2024
From chapel-lang#25326 Signed-off-by: Anna Rift <[email protected]>
riftEmber
approved these changes
Jun 20, 2024
riftEmber
added a commit
to riftEmber/chapel
that referenced
this pull request
Jun 20, 2024
From chapel-lang#25326 Signed-off-by: Anna Rift <[email protected]>
|
I think it's easiest for Anna's #25315 to roll this in as well. Consider this my approval of that commit 😄 |
riftEmber
added a commit
to riftEmber/chapel
that referenced
this pull request
Jun 25, 2024
From chapel-lang#25326 Signed-off-by: Anna Rift <[email protected]>
riftEmber
added a commit
that referenced
this pull request
Jun 27, 2024
…25315) Require that setting the module search path occurs before any other queries in the Context revision, if at all. This is to prevent unexpected results from its default empty value being used before it is set, as many queries rely on it. Implemented as an assertion that it is the first query run in the revision. Also change `testInteractive` to setup module search path earlier to be in line with this requirement. This fixes buggy behavior with `testInteractive --std`, in which we might not find standard module types, that was incidentally introduced in #25190. Depends on #25326 which should be merged first. [reviewed by @mppf and @DanilaFe , thanks!] Testing: - [x] paratest - [x] dyno tests - [x] `testInteractive` with basic program - [x] `chpl --dyno` with basic program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on files_with_contexts to get contexts with stdlib, as I suggested here: #25315 (comment).