Rename the "RedundantParentheses" rule to "ControlFlowParentheses" #25390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @bradcray's suggestion.
The
RedundantParentheses
rule (onmain
) refers to the rule that rejects parentheses around conditionals of control flow. Thus:However, Brad points out that the name "redundant parentheses" brings forth cases like
((expr))
, where there are two sets of parentheses. Brad's thought -- with which I agree -- is that we should leave "redundant parentheses" for the hypothetical((expr))
rule, and change the current rule for parentheses in ifs and loops to be "control flow parentheses".Reviewed by @jabraham17 -- thanks!
Testing
test/chplcheck