skip memleaks job for ConcurrentMap/LockFreeQueue/LockFreeStack #25446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #25392 replaced a set of futures that were locking down that (for ConcurrentMap, LockFreeQueue, and LockFreeStack) we failed with memory leaks (when passing '--memLeaks') with normal correctness tests. To lock down the known memory failures I also created a handful of other tests that lock down the "known leak" when passing in '--memLeaks' by execopt (this is the precedent we have for other known leaks as we have a script that detects such tests).
Anyway, we don't want the pure correctness tests to fail on our memleak job so we should skip them. This PR adjusts the skipif files to do that.