Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand completion support for language server #25991

Merged
merged 16 commits into from
Oct 21, 2024

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Sep 25, 2024

This PR expands upon our existing completion support to be location specific. Prior to this PR, only the module level scope was used to provide completion symbols. This PR changes that, so that visible symbols are computed based upon the users cursor.

With this PR, users will get an auto-complete suggestion of 'myVariable' when 'myV' is typed.

record myRecord {
  var  myVariable = 1;
  proc foo() {
    myV
  }
}

Implementation details

This PR uses the fact that the FileInfo visits nodes in order when building segments. So in the above example, the scope for myRecord is visited before foo. As each scope is entered, we keep track of the location, its Scope object, and the parent scopes. This is precomputed before a user ever requests a completion, so that when that occurs it is just a simple lookup.

[Reviewed by @DanilaFe]

@jabraham17 jabraham17 requested a review from DanilaFe September 25, 2024 15:53
Copy link
Contributor

@DanilaFe DanilaFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some preliminary comments

tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
tools/chpl-language-server/src/chpl-language-server.py Outdated Show resolved Hide resolved
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 requested a review from DanilaFe October 16, 2024 21:04
@jabraham17 jabraham17 merged commit 8337447 into chapel-lang:main Oct 21, 2024
8 checks passed
@jabraham17 jabraham17 deleted the better-completion branch October 21, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants