Make internal prefixes available to linter rules #26188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
DanilaFe
approved these changes
Nov 1, 2024
Signed-off-by: Jade Abraham <[email protected]>
|
I removed the kwargs. How do you feel about waiting for #26191 to add the tests? That will add |
|
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the internal prefixes (as specified by
--internal-prefix chpl_) be exposed to linter rules, rather than just the driver. Technically this was already possible, this PR just makes the naming based rules exclude the prefixes, such thatchpl_camelCaseis considered to be camelCase[Reviewed by @DanilaFe]