Fix symbol printing in the language server for a few cases #26216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes how symbols are printed in the language server for a few cases
new
expressions likenew (foo())()
owned C
,sync int
, andatomic real
foo!
andunmanaged C?
Additionally, when resolving these I fixed an issue where locations for something like
var x: int;
reported the location as including the;
. This is complicated by how we handle the default location for null rules in the grammar, but can be worked around by selectively setting the location in a few_opt
cases.Tested that
make test-cls
works,make test-frontend
works, andstart_test test/errors
works[Reviewed by @DanilaFe and @dlongnecke-cray]