Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol printing in the language server for a few cases #26216

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Nov 6, 2024

Fixes how symbols are printed in the language server for a few cases

  • new expressions like new (foo())()
  • types like owned C, sync int, and atomic real
  • postfix expressions like foo! and unmanaged C?

Additionally, when resolving these I fixed an issue where locations for something like var x: int; reported the location as including the ;. This is complicated by how we handle the default location for null rules in the grammar, but can be worked around by selectively setting the location in a few _opt cases.

Tested that make test-cls works, make test-frontend works, and start_test test/errors works

[Reviewed by @DanilaFe and @dlongnecke-cray]

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 merged commit 4fd9b8d into chapel-lang:main Nov 6, 2024
8 checks passed
@jabraham17 jabraham17 deleted the fix-symbol-printing branch November 6, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants