Update PERL email script name and parameter list. #26244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also renames the script to reflect what it is actually doing. The code does not send emails but instead creates an email file that is picked up by Jenkins to send to the team when a test fails. Signed-off-by: Tim Zinsky <[email protected]>
Signed-off-by: Tim Zinsky <[email protected]>
riftEmber
requested changes
Nov 15, 2024
riftEmber
requested changes
Nov 15, 2024
Signed-off-by: Tim Zinsky <[email protected]>
Signed-off-by: Tim Zinsky <[email protected]>
riftEmber
approved these changes
Nov 19, 2024
|
LGTM, but please hold off on merging until we get the chaos from LLVM 19 upgrade quieted down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps to explains what function this code now performs. The code does not send emails but instead creates an email file that is picked up by Jenkins to send to the team when a test fails. This change is to be merged before the module test code.