Fix compiler driver bug reading long dependency paths #26310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
force-pushed
the
fix-driver-restore
branch
2 times, most recently
from
c5e81a1 to
87c6100
Compare
riftEmber
force-pushed
the
fix-driver-restore
branch
from
bccc0d4 to
221742b
Compare
riftEmber
force-pushed
the
fix-driver-restore
branch
2 times, most recently
from
3f865ff to
8e1327f
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
fix-driver-restore
branch
3 times, most recently
from
3f2f707 to
a5c4f94
Compare
|
Closing as this is an inadequate solution to the problem of using hardcoded limits in general (#8757) -- explanation at #26261 (comment). Superseded by #26357 which includes this PR's changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug causing the compiler driver to crash when working with dependency paths longer than 4096 characters.
Fixed by reading with
std::getlinewhich has no line length limit, rather thanfgetswhich requires a (finite) buffer.Resolves #26261.
[reviewer info placeholder]
Testing:
--no-compiler-driverparatest