Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that module scope variables of extern types are default initalized #26417

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −0
Open

Make sure that module scope variables of extern types are default initalized #26417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eed618
prevent dead stores due to heapify pass
jabraham17 Dec 16, 2024
2c53452
make sure these tests run with `-multilocale`
jabraham17 Dec 16, 2024
632b6e5
fix typo
jabraham17 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compiler/passes/parallel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,6 +1145,12 @@ makeHeapAllocations() {
call->getStmtExpr()->insertBefore(new DefExpr(tmp));
call->getStmtExpr()->insertBefore(new CallExpr(PRIM_MOVE, tmp, new CallExpr(PRIM_GET_MEMBER_VALUE, use->symbol(), heapType->getField(1))));
use->replace(new SymExpr(tmp));
if (call->isPrimitive(PRIM_ZERO_VARIABLE)) {
// aftering zeroing the value, we need to set it back
// otherwise its a dead store
call->getStmtExpr()->insertAfter(
new CallExpr(PRIM_SET_MEMBER, use->symbol(), heapType->getField(1), tmp));
}
}
} else if (use->parentExpr)
INT_FATAL(var, "unexpected case");
Expand Down
1 change: 1 addition & 0 deletions test/extern/ferguson/NUMLOCALES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2
Loading