add annotations week of 1/23/25 #26594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stonea
commented
Jan 23, 2025
stonea
commented
- qthreads partial reversion (impacts thread ring shootout benchmark)
- Add annotation indicating we suspect a PR raising the number of gasnet threads may have influenced nbody perf on Apollo. If not due to that, it could also be due to some bimodal machine behavior, graph history makes it look like such behavior may exist.
- qthreads partial reversion - Suspect PR about raising number of gasnet threads may have influenced nbody perf. If not that it could also be due to some bimodal machine behavior. --- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.