Dyno resolve basic array indexing #26833
Open
+48
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
arifthpe
force-pushed
the
array-indexing
branch
6 times, most recently
from
5266ee6 to
6f081ef
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
arifthpe
changed the title
_validRankChangeArgs
|
@DanilaFe tests added, this is now actually ready for review |
2 tasks
DanilaFe
approved these changes
Mar 6, 2025
Comment on lines
+331
to
+342
| if (call.name() == "this") { | ||
| if (call.actual(0).type().type() && call.actual(0).type().type()->isArrayType() && | ||
| call.actual(0) | ||
| .type().type() | ||
| ->toArrayType() | ||
| ->eltType() | ||
| .type() | ||
| ->isStringType()) { | ||
| gdbShouldBreakHere(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
ready for review? Not so 😄
I see you're taking a page from my playbook here.
| @@ -1254,6 +1262,12 @@ void DisambiguationCandidate::computeConversionInfo(Context* context, int numAct | |||
| } | |||
| } | |||
|
|
|||
| if (canPass.passes() && canPass.promotes()) { | |||
| actualType = getPromotionType(context, fa1->actualType()).type(); | |||
| gdbShouldBreakHere(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get basic array indexing with
thisworking.Components to doing this:
ChapelArray._validRankChangeArgs. Logged in https://github.com/Cray/chapel-private/issues/6154 to be reverted once support is added.thisaccess on an array of strings, betweenarray.thisand promotedstring.this.Completes part of https://github.com/cray/chapel-private/issues/6107, and resolves https://github.com/Cray/chapel-private/issues/7196, which was blocked on array indexing.
Fixes the following spectests:
release/examples/spec/Arrays/Arrays/array-indexingrelease/examples/spec/Arrays/Arrays/array-indexing-2release/examples/spec/Arrays/Arrays/assoc-add-indexrelease/examples/spec/Arrays/Arrays/index-using-var-arg-tupleIncludes dyno testing for array indexing.
[reviewer info placeholder]
Testing: