Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

three_nn gpu implementation. #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

three_nn gpu implementation. #96

wants to merge 1 commit into from

Conversation

azaganidis
Copy link

Redefinition of three_nn by tensorflow operations instead of c++ on cpu. Significantly faster.

@azaganidis
three_nn gpu implementation.
87f702e 
Redefinition of three_nn by tensorflow operations instead of c++ on cpu. Significantly faster.
hi-zhengcheng
hi-zhengcheng suggested changes Oct 26, 2019
View reviewed changes
Copy link

@hi-zhengcheng hi-zhengcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it returns directly from tf.nn.top_k(-dist, k=3), I think it's wrong. Pay attention to the minus sign you added before dist. So it should be modified as:

values, indices = tf.nn.top_k(-dist, k=3)
return -values, indices

Nice implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-zhengcheng hi-zhengcheng hi-zhengcheng requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azaganidis @hi-zhengcheng