-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tables): add markdown and ascii border style for tables #480
base: table-resize
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It looks like Markdown wants the bottom and top sections of the Markdown one gone, i.e.
| LANGUAGE | FORMAL | INFORMAL |
|----------|--------------|-----------|
| Chinese | Nǐn hǎo | Nǐ hǎo |
| French | Bonjour | Salut |
| Russian | Zdravstvuyte | Privet |
| Spanish | Hola | ¿Qué tal? |
Rendered that looks like:
LANGUAGE | FORMAL | INFORMAL |
---|---|---|
Chinese | Nǐn hǎo | Nǐ hǎo |
French | Bonjour | Salut |
Russian | Zdravstvuyte | Privet |
Spanish | Hola | ¿Qué tal? |
d6ec1ba
to
551460f
Compare
Hey @meowgorithm. Thanks for noticing that. Unfortunately, it seems that it is not possible to address that by just changing that configuration, because:
So, to me, the right solution is to actually disable top and bottom borders with |
@andreynering Okay yeah, that makes sense. So let's see if docs will suffice for now. If not, we can cautiously consider a shorthand for markdown rendering later. On that note I'd add the note about |
551460f
to
a9174ce
Compare
a9174ce
to
288f6b8
Compare
697f90f
to
2caeaa0
Compare
Closes #424
Markdown style:
ASCII style: