Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add initial pipeline performing validation on PRs #8

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

dsloanm
Copy link
Contributor

@dsloanm dsloanm commented Nov 11, 2024

Adds a CI pipeline to the repository for validating prospective pull requests.

Follows the standards of the hpc-libs and slurm-charms repositories, performing the inclusive-naming-check then a validation-test. Validation installs dependencies opentofu and just, then runs just check, as defined in justfile. Currently this is tofu fmt -check -recursive, to enforce formatting, and tofu validate, to check Terraform file syntax.

Copy link
Contributor

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@NucciTheBoss NucciTheBoss self-requested a review November 12, 2024 19:59
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments and then I'm good to merge this PR 😃

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@dsloanm dsloanm requested a review from NucciTheBoss November 13, 2024 13:21
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it :shipit:

@NucciTheBoss NucciTheBoss merged commit 08ecf5b into charmed-hpc:main Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants