Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update snap base to core24 #2

Merged
merged 5 commits into from
May 28, 2024
Merged

feat: Update snap base to core24 #2

merged 5 commits into from
May 28, 2024

Conversation

NucciTheBoss
Copy link
Member

This pull request rebases the Slurm snap from core22 to core24. Why? librocm-dev and librocm-smi-dev are now in the Ubuntu package archive, so we do not need to pull those packages from the custom PPA that I have set up on Launchpad. Slurm uses these packages for taking inventory of the AMD GPUs available within your cluster.

Other changes:

  1. Simplified the layout of the overlays directory. Rather than having two separate parts for both munge and slurm, just have one that stages all the sbin/ wrapper scripts.
  2. /var/run -> /run. /run is the standard directory to use for variable runtime data; /var/run is the legacy location.
  3. Added an .editorconfig so that we don't have to constantly reconfigure editors when working with YAML files.
  4. Refactored layout of the snapcraft.yaml recipe so that it is a bit easier to read.

@NucciTheBoss
chore: Add .editorconfig file
79856a7 
Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss
refactor: Consolidate overlays into one part
7f48227 
Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss
refactor: /var/run -> /run
bbea1c7 
Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss
feat: Upgrade to core24
638ac14 
Upgrade to core24 as core ROCM libraries are now in archive.
We do not need to pull from ubuntu-hpc PPA as using PPAs is
discouraged for production workloads.

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss NucciTheBoss added the enhancement New feature or request label May 23, 2024
@NucciTheBoss NucciTheBoss requested a review from jedel1043 May 23, 2024 14:03
@NucciTheBoss NucciTheBoss self-assigned this May 23, 2024
@NucciTheBoss NucciTheBoss mentioned this pull request May 23, 2024
Merged
jedel1043
jedel1043 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Had a small nitpick about a comment, but it doesn't really block merging.

slurmhelpers/hooks.py Outdated Show resolved Hide resolved
@NucciTheBoss @jedel1043
docs: Clarify /run comment
69bdda4 
Co-authored-by: José Julián Espina <[email protected]>
@NucciTheBoss NucciTheBoss merged commit c34bb2d into main May 28, 2024
3 checks passed
@NucciTheBoss NucciTheBoss deleted the update-core24 branch May 28, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees

@NucciTheBoss NucciTheBoss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NucciTheBoss @jedel1043