fix: remove slurm.conf location override from env #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch to `src/common/Makefile.am` sets the default location for slurm.conf to $SNAP_COMMON/etc/slurm/slurm.conf. Having this environment variable around messes with the CLI commands when running in configless mode as these commands will still look for slurm.conf in $SNAP_COMMON/etc/slurm/slurm.conf. Rather than under /var/spool. Note that you will possibly need to set `SlurmdSpoolDir` for the CLI commands to locate the cached slurm.conf when running in configless mode. This option should be set in the main slurm controller. Signed-off-by: Jason C. Nucciarone <[email protected]>
|
This was actually enough to make configless work, and I didn't need to set the spool dir. It would still be worth solving #22 though. |
jedel1043
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch to
src/common/Makefile.amsets the default location for slurm.conf to $SNAP_COMMON/etc/slurm/slurm.conf. Having this environment variable around messes with the CLI commands when running in configless mode as these commands will still look for slurm.conf in $SNAP_COMMON/etc/slurm/slurm.conf. Rather than under /var/spool.Note that you will possibly need to set
SlurmdSpoolDirfor the CLI commands to locate the cached slurm.conf when running in configless mode. This option should be set in the main slurm controller.Misc.
You can use the following command to set the slurmd spool directory on the main slurm controller node (slurmctld):
snap set slurm slurm.slurmd-spool-dir=/var/snap/slurm/common/var/libIdeally this will be automatically set at installation once we have the fix for #19