feat: add initial integration tests for the slurm snap #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
|
Uhhh, why didn't the CI trigger for this PR? |
YAML stands for (Y)AML (A)in't (M)aking my (L)ife any easier |
NucciTheBoss
force-pushed
the
add-integration-tests
branch
from
2feb5e9 to
284e3fd
Compare
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
force-pushed
the
add-integration-tests
branch
from
a6f1939 to
6e5790a
Compare
|
@jedel1043 this is ready for review! Fixed the issues with the integration test. Just needed to disable IPv6 so that the |
jedel1043
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds integration tests for the Slurm snap. We need integration tests so that we can ensure that changes that we make to the snap will not break the snap and be detrimental to our users.
Things added:
Fixes: #31